Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkite pipeline to verify build and publish package #35

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Buildkite pipeline to verify build and publish package #35

merged 7 commits into from
Dec 11, 2024

Conversation

sanjain-progress
Copy link
Collaborator

  • Build habitat package
  • Publish habitat package

@sanjain-progress sanjain-progress requested review from a team as code owners December 2, 2024 12:00
@sanjain-progress sanjain-progress force-pushed the sanjain/chef-17476/github_action branch 3 times, most recently from 38fe480 to f039418 Compare December 3, 2024 19:59
@tpowell-progress
Copy link
Collaborator

@sanjain-progress don't forget git commit -s to DCO your commits

jaymzh
jaymzh requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems mostly OK, but I have questions... building these should happen on main too, no?

Also, you need DCO.

Also, please updated your edit to add newlines in the final line of your lines.

@sanjain-progress sanjain-progress changed the title Github action pipeline Added Github action pipeline to verify build and publish package Dec 4, 2024
@sanjain-progress sanjain-progress force-pushed the sanjain/chef-17476/github_action branch from f039418 to 914860f Compare December 4, 2024 05:38
@sanjain-progress sanjain-progress force-pushed the sanjain/chef-17476/github_action branch from 914860f to e940dcc Compare December 4, 2024 06:51
@sanjain-progress
Copy link
Collaborator Author

This seems mostly OK, but I have questions... building these should happen on main too, no?

Also, you need DCO.

Also, please updated your edit to add newlines in the final line of your lines.

@jaymzh Yes, all these builds should be against the main branch. We are doing this to create the workstation as a Habitat (hab) package. Raising the changes against the workstation-LTS branch is a precaution to ensure nothing breaks. In the future, we can replace workstation-LTS with main.

@sanjain-progress sanjain-progress requested review from a team and jaymzh December 4, 2024 10:28
@sanghinitin
Change pipeline to expeditor
36b3cc6 
Signed-off-by: nitin sanghi <[email protected]>
@sanghinitin
Fix pipeline name
6b1b90a 
Signed-off-by: nitin sanghi <[email protected]>
@sanghinitin
Change pipeline to expeditor
36a3a12 
Signed-off-by: nitin sanghi <[email protected]>
@sanghinitin
remove pipeline create config
0a29508 
Signed-off-by: nitin sanghi <[email protected]>
@sanghinitin
pkg indent fix
d798e4e 
Signed-off-by: nitin sanghi <[email protected]>
@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

jaymzh
jaymzh approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, works for me, but I'd REALLY appreciate the Workstation team publishing somewhere this list of alllll the work being pooled up behind this Workstation-LTS branches and what the plan for merging it is.

@sanjain-progress sanjain-progress changed the title Added Github action pipeline to verify build and publish package Buildkite pipeline to verify build and publish package Dec 11, 2024
@nikhil2611 nikhil2611 merged commit bcb33de into workstation-LTS Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil2611 nikhil2611 nikhil2611 approved these changes

@jaymzh jaymzh jaymzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sanjain-progress @tpowell-progress @jaymzh @nikhil2611 @sanghinitin